Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve install.sh and release ci #2301

Merged
merged 1 commit into from
Nov 5, 2023
Merged

improve install.sh and release ci #2301

merged 1 commit into from
Nov 5, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Nov 3, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a07c4d7) 55.42% compared to head (75b01e5) 55.28%.

❗ Current head 75b01e5 differs from pull request most recent head ca0b790. Consider uploading reports for the commit ca0b790 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
- Coverage   55.42%   55.28%   -0.14%     
==========================================
  Files         326      326              
  Lines       34471    34478       +7     
==========================================
- Hits        19104    19058      -46     
- Misses      13076    13133      +57     
+ Partials     2291     2287       -4
Flag Coverage Δ
cluster 44.46% <ø> (-0.21%) ⬇️
dm 25.46% <ø> (-0.01%) ⬇️
playground 15.37% <ø> (+0.04%) ⬆️
tiup 15.67% <ø> (ø)
unittest 22.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm /merge

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 5, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 5, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-05 16:51:29.233382203 +0000 UTC m=+3403886.820492348: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot merged commit 1e2e855 into pingcap:master Nov 5, 2023
20 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nexustar @codecov-commenter @kaaaaaaang